-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix upsample shape infer bug #8105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Attr("output_size")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么设置eps=1e-5呢
准备基于output_size重构一下op,先忽略这个改动,会去掉。 |
…/oneflow into fix_upsample_shape_infer_bug
* fix_upsample_shape_infer_bug * fix 5 nearest * add 5 nearest test * fix 5 nearest test * fix 1 linear * fix 4 bilinear * fix 4 bicubic * modify bicubic 2d file name * fix 5 trilinear * fix exception info * fix exception info * fix bug * modify interpolate * change float to double * rm useless SI64ArrayAttr: in OneFlowUserOps * rm useless import in cpp * update * add judge for output_size * update oneflow/oneflow/core/autograd/gradient_funcs/upsample.cpp * add grad in td * test failed * fix small failed case in upsample * solve test error * change float to double * align to fix_upsample_shape_infer_bug * align to fix_upsample_shape_infer_bug Co-authored-by: BBuf <1182563586@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interpolate.py 103行这个地方还有必要保留scale吗
这个暂时去不掉,因为scale不是Optional的,改起来工作量依然比较大,准备下个pr来做。 |
Speed stats:
|
Speed stats:
|
CI failed when running job: cpu-module. PR label automerge has been removed |
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8105/ |
Speed stats:
|
CI failed when running job: cpu-module. PR label automerge has been removed |
Speed stats:
|
Speed stats:
|
CI failed when running job: cpu-module. PR label automerge has been removed |
Speed stats:
|
fix upsample shape infer bug caused by float precision. linked: Oneflow-Inc/libai#260 (comment)