Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress gcc11 false positive warning #8401

Merged
merged 5 commits into from
Jun 13, 2022
Merged

suppress gcc11 false positive warning #8401

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69aa969
suppress gcc11 false positive warning
daquexian Jun 11, 2022
78c5859
Merge branch 'master' into fix_gcc11_false_positive
mergify[bot] Jun 13, 2022
4b8aee8
Merge branch 'master' into fix_gcc11_false_positive
mergify[bot] Jun 13, 2022
0234b2c
Merge branch 'master' into fix_gcc11_false_positive
mergify[bot] Jun 13, 2022
8a9b4a3
Merge branch 'master' into fix_gcc11_false_positive
mergify[bot] Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions oneflow/core/common/cached_caller.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ limitations under the License.
#include "oneflow/core/common/maybe.h"
#include "oneflow/core/common/tuple_hash.h"

// gcc 11 falsely reports error:
// ‘void operator delete(void*, std::size_t)’ called on unallocated object ‘cache’
// However, `DeleteAndClear` is only called after `cache` is allocated in
// if (cache == nullptr) block.
// The reason not to use #pragma GCC diagnostic push/pop is that gcc reports
// the error on the caller of `ThreadLocalCachedCall`.
// TODO: replace ThreadLocalCachedCall with ThreadLocalCached decorator?
#if defined(__GNUC__) && !defined(__clang__) && __GNUC__ >= 11
#pragma GCC diagnostic ignored "-Wfree-nonheap-object"
#endif

namespace oneflow {

template<typename T>
Expand Down