Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify bias_add_op.cpp,delete unnecessary checks and improve the error message #8524

Merged
merged 9 commits into from
Jun 30, 2022
Merged

Modify bias_add_op.cpp,delete unnecessary checks and improve the error message #8524

merged 9 commits into from
Jun 30, 2022

Conversation

small1945
Copy link
Contributor

@small1945 small1945 commented Jun 29, 2022 •
edited
Loading

  • 部分CHECK在functor层已经调用，只针对functor未报错的CHECK进行测试

@small1945 small1945 changed the title Delete unnecessary checks and improve the error message Modify bias_add_op.cpp,delete unnecessary checks and improve the error message Jun 29, 2022
@small1945 small1945 requested review from zhongshsh and wyg1997 June 30, 2022 01:14
@small1945 small1945 requested a review from oneflow-ci-bot June 30, 2022 02:57
@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@github-actions
Copy link
Contributor

CI failed when running job: cuda-misc. PR label automerge has been removed

@small1945 small1945 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 30, 2022 05:30
@mergify mergify bot merged commit 43d8c30 into master Jun 30, 2022
@mergify mergify bot deleted the Mod_biasAdd branch June 30, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongshsh zhongshsh zhongshsh approved these changes

@wyg1997 wyg1997 wyg1997 approved these changes

@guo-ran guo-ran guo-ran approved these changes

@BBuf BBuf Awaiting requested review from BBuf

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge documentation enhancement need-check-error-message op test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@small1945 @guo-ran @wyg1997 @zhongshsh @oneflow-ci-bot