Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated np.bool #9649

Merged
merged 6 commits into from
Dec 23, 2022
Merged

replace deprecated np.bool #9649

merged 6 commits into from
Dec 23, 2022

Conversation

daquexian
Copy link
Contributor

@daquexian daquexian commented Dec 23, 2022 •
edited
Loading

把 deprecated 的 np.bool 替换为 bool

@daquexian
replace np.bool with bool
3b6185b 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian
use np.bool_ in _ONEFLOW_DTYPE_TO_NUMPY_DTYPE
044f6ff 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian marked this pull request as ready for review December 23, 2022 03:26
@daquexian
use bool instead of np.bool_
b6ca494 
Signed-off-by: daquexian <daquexian566@gmail.com>
@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@jackalcooper jackalcooper requested review from oneflow-ci-bot and removed request for oneflow-ci-bot December 23, 2022 06:56
@github-actions
Copy link
Contributor

Speed stats:

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.2ms (= 13916.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.5ms (= 16047.4ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 160.5ms / 139.2ms)

OneFlow resnet50 time: 85.0ms (= 8500.5ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.4ms (= 10142.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 101.4ms / 85.0ms)

OneFlow resnet50 time: 57.5ms (= 11505.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.0ms (= 15605.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.36 (= 78.0ms / 57.5ms)

OneFlow resnet50 time: 45.9ms (= 9184.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 69.1ms (= 13810.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.50 (= 69.1ms / 45.9ms)

OneFlow resnet50 time: 39.8ms (= 7963.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.3ms (= 13666.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.72 (= 68.3ms / 39.8ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9649/

@mergify mergify bot merged commit 28a893d into master Dec 23, 2022
@mergify mergify bot deleted the remove_np_bool branch December 23, 2022 14:35
@daquexian daquexian mentioned this pull request Dec 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackalcooper jackalcooper jackalcooper approved these changes

@Flowingsun007 Flowingsun007 Flowingsun007 approved these changes

@BBuf BBuf Awaiting requested review from BBuf

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge bug enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daquexian @jackalcooper @Flowingsun007 @oneflow-ci-bot