Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-11494: Avoid rendering GraphDB properties in quotes #156

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

mihailradkov
Copy link
Contributor

The config maps for both GraphDB and the cluster proxy were rendering all values from configuration.properties in quotes which is problematic because some properties are expected as non-strings.

Removed | quote to allow non-string values such as booleans and numbers.

Prepared Helm release v11.3.3

mihailradkov and others added 3 commits January 15, 2025 09:55
The config maps for both GraphDB and the cluster proxy were rendering all values
from `configuration.properties` in quotes which is problematic because some
properties are expected as non-strings.

Removed `| quote` to allow non-string values such as booleans and numbers.
@mihailradkov
Copy link
Contributor Author

Tested with:

configuration:
  properties:
    graphdb.one: string-property
    graphdb.two: 2
    graphdb.three: true
    graphdb.four: [1,2]
    graphdb.five:
      hey: ho
    graphdb.six: ala\nbala
    graphdb.seven: "\"\""
    graphdb.eight: ''
    graphdb.nine:
    graphdb.ten: '10'
    graphdb.eleven: 'true'

which rendered to:

##### Overrides from values.yaml #####
graphdb.one=string-property
graphdb.two=2
graphdb.three=true
graphdb.four=[1 2]
graphdb.five=map[hey:ho]
graphdb.six=ala\nbala
graphdb.seven=""
graphdb.eight=
graphdb.eleven=true
graphdb.ten=10

@mihailradkov mihailradkov self-assigned this Jan 15, 2025
@mihailradkov mihailradkov requested a review from yaskoo January 15, 2025 08:13
@mihailradkov mihailradkov merged commit ecf33e7 into main Jan 15, 2025
@mihailradkov mihailradkov deleted the fix/GDB-11494-configurations-rendering branch January 15, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants