Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added: report License file name #202

Merged
merged 2 commits into from
Sep 1, 2023
Merged

added: report License file name #202

merged 2 commits into from
Sep 1, 2023

Conversation

thorstendb-ARM
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023 •
edited
Loading

Codecov Report

Patch coverage is 37.50% of modified lines.

Files Changed Coverage
cmd/utils/encodedProgress.go ø
cmd/installer/pack.go 37.50%

📢 Thoughts on this report? Let us know!.

@thorstendb-ARM
added:
5660704 
- return without error for "--encoded-progres" if no license present
- skip DisplayAndWaitForEULA()
- test for license file
- description for "* L: License file follows"
@thorstendb-ARM thorstendb-ARM requested a review from bgn42 September 1, 2023 12:22
@thorstendb-ARM thorstendb-ARM marked this pull request as ready for review September 1, 2023 12:47
@thorstendb-ARM thorstendb-ARM merged commit 9cdab34 into main Sep 1, 2023
@thorstendb-ARM thorstendb-ARM deleted the cpackget#196_2 branch September 1, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgn42 bgn42 bgn42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thorstendb-ARM @codecov-commenter @bgn42