Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack Installer fails to install packs with a backslash in the license file path #238

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

thorstendb-ARM
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM commented Jan 9, 2024

fixed:
golang "path" object has issues handling backslash, changed to filepath object.

also see: #232

… file path

fixed:
golang "path" object has issues handling backslash, changed to filepath object.
Copy link

codeclimate bot commented Jan 9, 2024

Code Climate has analyzed commit 20febe2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.7% (0.0% change).

View more on Code Climate.

@jkrech jkrech requested a review from bgn42 January 9, 2024 08:48
@thorstendb-ARM thorstendb-ARM removed the request for review from soumeh01 January 9, 2024 09:48
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit c8a87e8 into main Jan 9, 2024
16 checks passed
@jkrech jkrech deleted the pathBackslashIssue branch January 9, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants