Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch level select with @~ #338

Merged
merged 11 commits into from
Sep 2, 2024
Merged

Patch level select with @~ #338

merged 11 commits into from
Sep 2, 2024

Conversation

bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Aug 30, 2024

Also changed some error messages to be more informative

@bgn42 bgn42 requested a review from jkrech August 30, 2024 13:25
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, but please see my questions.

cmd/commands/add.go Outdated Show resolved Hide resolved
cmd/installer/pack.go Show resolved Hide resolved
Copy link

codeclimate bot commented Sep 2, 2024

Code Climate has analyzed commit 082a200 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 73.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit f4ac119 into main Sep 2, 2024
15 of 16 checks passed
@jkrech jkrech deleted the patchLevelSelect branch September 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants