[svdconv] Fix infinite recursion in SvdItem::GetEffectiveProtection()
method
#1793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the
SvdItem::GetEffectiveProtection()
method, which previously resulted in a segmentation fault (SIGSEGV) due to infinite recursion.The previous implementation called
GetEffectiveProtection()
recursively within the for-loop, causing an infinite recursion if no protection value was found. This led to stack overflow and a crash. The solution replaces the recursive call with a call toGetProtection()
, which checks the protection value without triggering recursion.