Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version string #1848

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

spcaipers-arm
Copy link
Collaborator

No description provided.

Copy link

Test Results

 6 files  12 suites   0s ⏱️
26 tests 26 ✅ 0 💤 0 ❌
78 runs  78 ✅ 0 💤 0 ❌

Results for commit 3ac18c1.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech requested review from thorstendb-ARM and removed request for JonatanAntoni November 13, 2024 14:57
@jkrech
Copy link
Member

jkrech commented Nov 13, 2024

@thorstendb-ARM do you see any problems with these changes to the svdconv output messages?

@soumeh01 soumeh01 merged commit dc432f5 into Open-CMSIS-Pack:main Nov 14, 2024
27 checks passed
@soumeh01 soumeh01 deleted the outbound/svdconvVersion branch November 14, 2024 07:37
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (cb7fb18) to head (3ac18c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/svdconv/SVDConv/src/ParseOptions.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   64.92%   64.91%   -0.01%     
==========================================
  Files         163      163              
  Lines       34457    34452       -5     
  Branches    19976    19971       -5     
==========================================
- Hits        22370    22365       -5     
  Misses       7958     7958              
  Partials     4129     4129              
Flag Coverage Δ
svdconv-cov 40.23% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/svdconv/SVDConv/src/SVDConv.cpp 42.99% <ø> (-0.27%) ⬇️
tools/svdconv/SVDConv/src/SvdOptions.cpp 52.86% <100.00%> (-1.18%) ⬇️
tools/svdconv/SVDConv/src/ParseOptions.cpp 50.55% <50.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants