Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance add_dirs with exclusion feature #61

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Enhance add_dirs with exclusion feature #61

merged 1 commit into from
Mar 12, 2024

Conversation

JonatanAntoni
Copy link
Contributor

  • Ignore vsc files/folders by default
  • Allow custom exclude patterns in .gpignore file

- Ignore vsc files/folders by default
- Allow custom exclude patterns in .gpignore file
Folder from outside the pack root (e.g., `../path/to/src`) are copied without hierarchy into the build
folder (i.e., resulting in `<build>/src`). For customizing the layout consider the `postprocess` hook.

Folders from outside the pack root (e.g., `../path/to/src`) are copied without hierarchy into the build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

Folders from outside the pack root (e.g., `../path/to/src`) are copied without hierarchy into the build
folder (i.e., resulting in `<build>/src`).

Files and folders used by common version control system (vsc) are ignored by default (`--exclude-vcs`).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

folder (i.e., resulting in `<build>/src`).

Files and folders used by common version control system (vsc) are ignored by default (`--exclude-vcs`).
By providing a `.gpignore` file in any folder additional patterns can be excluded (`--exclude-ignore`).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit 490c7cd and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 4

View more on Code Climate.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.77%. Comparing base (f473c42) to head (490c7cd).

Files Patch % Lines
lib/patches 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   74.11%   73.77%   -0.34%     
==========================================
  Files           7        7              
  Lines         792      797       +5     
==========================================
+ Hits          587      588       +1     
- Misses        205      209       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonatanAntoni JonatanAntoni merged commit a86043d into main Mar 12, 2024
5 checks passed
@JonatanAntoni JonatanAntoni deleted the add_dirs branch March 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants