Allow to load signed result URL in load_ml_model #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for asset in assets: | ||
| if "ml-model:checkpoint" in assets[asset].get('roles', []): | ||
| checkpoints.append(assets[asset]) | ||
| if "ml_model_metadata.json" in model_id: |
There was a problem hiding this comment.
Maybe use endswith instead of in. I don't think this edge case will ever occur but better to be safe.
|
The code looks good but I'm not sure why ml_model_metadata.json has a different json structure compared to other files. I suspect the signed urls are the ones that don't end with 'ml_model_metadata.json'? If so, we should be careful with splitting up based on the name of the file. Users should be able to choose any filename they want. |
|
PR put on draft and might close later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading from a signed results URL avoids credentials issues.
Another way could have been to sign the content of the
/ml_model_metadata.jsonurl.