Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper callable support in fit_curve and related #229

Closed
soxofaan opened this issue Sep 6, 2021 · 0 comments · Fixed by #230
Closed

Proper callable support in fit_curve and related #229

soxofaan opened this issue Sep 6, 2021 · 0 comments · Fixed by #230

Comments

@soxofaan
Copy link
Member

soxofaan commented Sep 6, 2021

from openEOPlatform/documentation#10

curve_fitting = l2a_bands.fit_curve(
    parameters=[1,1,1], # Initial guess of the parameters
    dimension="t",      # Fit the function along the temporal dimension
    function=l2a_bands._get_callback(fit_function, parent_parameters=["data","parameters"])
)

it's unfortunate that you have to call a private method l2a_bands._get_callback like that, we should make sure that you can just do function=fit_function directly

@soxofaan soxofaan changed the title Proper callable support in curve_fit and related Proper callable support in fit_curve and related Sep 6, 2021
soxofaan added a commit that referenced this issue Sep 6, 2021
soxofaan added a commit that referenced this issue Sep 6, 2021
soxofaan added a commit that referenced this issue Sep 14, 2021
soxofaan added a commit that referenced this issue Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant