job manager tests: fail on any warning #662
Draft
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
commented
Nov 14, 2024
tests/extra/test_job_management.py
Outdated
| @@ -77,6 +77,8 @@ def sleep_mock(): | |||
| yield sleep | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("default:.*`output_file` argument is deprecated.*:DeprecationWarning") | |||
| @pytest.mark.filterwarnings("error") | |||
There was a problem hiding this comment.
Apparently it is also possible to set these markers at module level, (instead of only on this test class), with the pytestmark module global var according to https://docs.pytest.org/en/stable/how-to/capture-warnings.html#pytest-mark-filterwarnings
soxofaan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to harden the job manager tests: fail hard on any warning (except our own deprecation warnings)
related to #641, #656