Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds process linear_scale_range #96

Merged
merged 2 commits into from
Nov 4, 2019

Conversation

lforesta
Copy link
Contributor

in the client the process stretch_colors was correctly deprecated in favor of linear_scale_range, but this one was not present.

- it was hard-coded to "data", which clashes with some processes
@jdries jdries merged commit 534e11a into Open-EO:master Nov 4, 2019
@soxofaan
Copy link
Member

soxofaan commented Nov 5, 2019

minor note: this linear_scale_range(self, inputMin, inputMax, outputMin, outputMax) does not follow the standard python code style convention of using under_scores instead of dromedaryCase for variables and arguments. It should be something like

def linear_scale_range(self, input_min, input_max, output_min, output_max) -> 'ImageCollection':

@soxofaan
Copy link
Member

soxofaan commented Nov 5, 2019

I can quickly fix it myself, unless you want to do it @lforesta

@lforesta
Copy link
Contributor Author

lforesta commented Nov 6, 2019

ah yes, I actually copy-pasted that from the openeo-processes specification, please @soxofaan feel free to change that, thanks! I'll try to remember that in case of other PRs :)

soxofaan added a commit that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants