Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the model.Message description and tests now using op_id #2470

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

ReimarBauer
Copy link
Member

@ReimarBauer ReimarBauer commented Aug 17, 2024

Purpose of PR?:

Fixes #2456

Does this PR introduce a breaking change?
no

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • [] PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The casts should help with potential type mismatches that otherwise wouldn't be caught when testing against SQLite, since SQLite does not care about types at all and will take basically anything thrown at it.

@ReimarBauer ReimarBauer merged commit 02999a0 into Open-MSS:stable Aug 20, 2024
9 of 11 checks passed
@ReimarBauer ReimarBauer deleted the i2456 branch August 20, 2024 12:48
@ReimarBauer
Copy link
Member Author

#2434

joernu76 pushed a commit that referenced this pull request Aug 28, 2024
* removing pinned xmlschema (#2117)

* Stop ignoring some test files (#2291)

* Reconfigured tutorial videos for RTFD (#2458)

* changed to videos/

* use mss style on rtfd

* fix urls and text (#2460)

* Bump benc-uk/workflow-dispatch from 1.2.3 to 1.2.4 (#2450)

Bumps [benc-uk/workflow-dispatch](https://github.com/benc-uk/workflow-dispatch) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/benc-uk/workflow-dispatch/releases)
- [Commits](benc-uk/workflow-dispatch@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: benc-uk/workflow-dispatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Limit video width to the containing block's width (#2463)

* pinning of libtiff is not needed but blocks a more recent libxml2 and others (#2469)

* fixed the model.Message description and tests now using op_id (#2470)

* bug fix for incomplete xml imports (#2468)

validate xml content

* prepare v9.2.0 (#2481)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matthias Riße <9308656+matrss@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants