Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented emulator for #190 #289

Merged
merged 186 commits into from
Sep 11, 2022
Merged

Conversation

simonmicro
Copy link
Member

@simonmicro simonmicro commented Sep 3, 2022

Closes #190

Still needs (merge into this branch to implement them):

@simonmicro simonmicro changed the base branch from master to develop September 3, 2022 22:33
@simonmicro simonmicro self-assigned this Sep 3, 2022
@simonmicro simonmicro force-pushed the feature/emulator/SDL_rebased branch from 35fb1c5 to dd80b23 Compare September 3, 2022 22:49
@simonmicro simonmicro changed the title Implemented basic variant of emulator for #190 Implemented emulator for #190 Sep 3, 2022
@RuffaloLavoisier
Copy link
Member

RuffaloLavoisier commented Sep 4, 2022

I think it'd be nice to create a docker usage on the Readme(self assignment me :) )and create a developer section add emulator parts to the official documents.

Developer
- dev tool (emulator)

@simonmicro simonmicro force-pushed the feature/emulator/SDL_rebased branch 2 times, most recently from 9a20513 to f67dbf6 Compare September 6, 2022 10:01
@RuffaloLavoisier
Copy link
Member

How about you to re-implement a circular surface of the watch?
This allows you to see the maximum value and exactly where it is on the face of the clock as you proceed with the UI operation. (You can see if the drawn image or text is off the clock boundary)

See : https://github.com/Open-Smartwatch/lib-open-smartwatch/blob/267d00a2ac76a70dc5a589af4bfa1ce05b70d744/FakeArduinoWindowSDL.h#L113

@simonmicro simonmicro force-pushed the feature/emulator/SDL_rebased branch from 5d34a73 to 9e5183e Compare September 8, 2022 19:10
@simonmicro
Copy link
Member Author

How about you to re-implement a circular surface of the watch? This allows you to see the maximum value and exactly where it is on the face of the clock as you proceed with the UI operation. (You can see if the drawn image or text is off the clock boundary)

See : https://github.com/Open-Smartwatch/lib-open-smartwatch/blob/267d00a2ac76a70dc5a589af4bfa1ce05b70d744/FakeArduinoWindowSDL.h#L113

We could add this to the FakeDisplay or (better) OswUI instance and control that "underlay" using a public accessible boolean (like the way how I can disable the framerate limiter.

@simonmicro simonmicro force-pushed the feature/emulator/SDL_rebased branch from 3f52c86 to 4fec0dd Compare September 8, 2022 21:48
Copy link
Member

@RuffaloLavoisier RuffaloLavoisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me, The minor point has been modified inside.

Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
emulator/include/Emulator.hpp Outdated Show resolved Hide resolved
emulator/include/Preferences.h Outdated Show resolved Hide resolved
src/animations/demos/README.md Outdated Show resolved Hide resolved
src/animations/demos/text.cpp.inactive Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceBinary.cpp Outdated Show resolved Hide resolved
@simonmicro simonmicro force-pushed the feature/emulator/SDL_rebased branch from e694bff to 90c7d16 Compare September 11, 2022 14:14
@simonmicro simonmicro force-pushed the feature/emulator/SDL_rebased branch from 90c7d16 to 57e29bb Compare September 11, 2022 14:17
@simonmicro simonmicro merged commit 749c8db into develop Sep 11, 2022
@simonmicro simonmicro deleted the feature/emulator/SDL_rebased branch September 11, 2022 16:37
@RuffaloLavoisier RuffaloLavoisier mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSW-OS Emulator
5 participants