Feature/alarm

[xbohdan]

No description provided.

[simonmicro]

I've noted some similarities with the other PRs. Could you please leave a note in them, which PR is based upon which other one? This would save me some time by not reviewing your changes twice (and commenting them :P ).

[simonmicro]

...and when should this be merged? After or before #343 ?

[akmal-threepointsix]

...and when should this be merged? After or before #343 ?

The order does not matter, since they are independent features.

And with any order there will be few merge conflicts 😃, but they are very easy to fix 😉.

[simonmicro]

Well, while the comment inside the unit test for the OswServiceTaskNotifier may not be true anymore, I'm not a fan of implementing it myself... @cutieskye @akmal-threepointsix ?

[simonmicro]

A note regarding the "fixtures": A fixture is something which prepares / resets something for one specific unit-test. In the other tests those are used to start/prepare the emulator if e.g. interaction with the HAL is needed or used to reset/prepare the Preferences/NVS before every test run. Your unit-tests are therefore not really well placed inside the fixtures-folder. Furthermore, a fixture shall be independent of the test, so others could potentially reuse them as needed.

[akmal-threepointsix]

I resolved all conflicts.

Well, while the comment inside the unit test for the OswServiceTaskNotifier may not be true anymore, I'm not a fan of implementing it myself... @cutieskye @akmal-threepointsix ?

I removed outdated comment and added a new comment. Unfortunately, I don't have energy to write new unit tests 😢

[RuffaloLavoisier]

LGTM - We don't have a trigger module at the moment, but the idea is great!

[akmal-threepointsix]

Hmm, one check failed. But it looks like it is not our fault, it just could not download some package 🤔. Could someone restart all checks?

[simonmicro]

Hmm, one check failed. But it looks like it is not our fault, it just could not download some package thinking. Could someone restart all checks?

Consider it done :)

[simonmicro]

I'm sorry, but your branch is somewhat out-of-sync with the develop, so I wasn't able to merge it. I've gone ahead and merged #350 before yours (because of your conflicts). Would it be possiblee that you rebase on top of the current develop branch? I'll try to merge yours ASAP 😓

[akmal-threepointsix]

Erm sorry, I accidentally merged "develop" into this branch instead of rebasing. Is it ok?

[simonmicro]

Nope, the "Merge Queue" is still rejecting this branch... If you can't solve it I would swing my admin-mode and hammer it in :)