Bug/gif bg flag #363
Merged
Bug/gif bg flag #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GIF_BG to the ci
Also removed LTT demo (as it was too big anyways)
Extended flag extraction from docs to include additional, required flags
RuffaloLavoisier
requested changes
Apr 19, 2023
|
Here you go @RuffaloLavoisier 😉 |
|
@RuffaloLavoisier I have to admit, that I'm no real fan of concatenating |
RuffaloLavoisier
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362
I also needed to redesign the workflows to work with multiple flags defined at the same time, as the build-script was not proper cleaning all defines before (which caused size-problems with the
GIF_BGflag). After changing that, too many flags were removed, so I re-engineered the flag-extraction from the docs to just contain all required ones.