-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PR #376 #382
Merged
Merged
Updated PR #376 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmicro
added
⭐ enhancement
New feature or request
src/osw-app
This PR / issue impacts the current release of the OS
labels
Apr 6, 2024
simonmicro
force-pushed
the
PR_376/LorenzoSciaccaOrg_master
branch
from
April 6, 2024 08:05
5ee7be9
to
9a962f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
simonmicro
force-pushed
the
PR_376/LorenzoSciaccaOrg_master
branch
from
April 6, 2024 08:29
4802e96
to
c6a07d5
Compare
simonmicro
added
✔️ merge when CI passed
Note for the maintainers: Merge the PR ASAP after the CI finished
and removed
✔️ merge when CI passed
Note for the maintainers: Merge the PR ASAP after the CI finished
labels
Apr 6, 2024
Nope, found multiple SEGFAULT-s in the emulator due to this app. I'll patch these first. |
simonmicro
added
the
✔️ merge when CI passed
Note for the maintainers: Merge the PR ASAP after the CI finished
label
Apr 6, 2024
+The OSW weather app is now supported also when using the emulator. +Documentation update
Cleanup debug print
Error print
Warnings
Errors and warnings
Warnings
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
- out-of-memory reads - use of incorrectly cached HAL reference - underflow of size_t - wrong signedness comparison - botched load-from-file in emulator erro handling Signed-off-by: simonmicro <simon@simonmicro.de>
simonmicro
force-pushed
the
PR_376/LorenzoSciaccaOrg_master
branch
from
April 6, 2024 09:30
561f6df
to
7fdd287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✔️ merge when CI passed
Note for the maintainers: Merge the PR ASAP after the CI finished
src/osw-app
This PR / issue impacts the current release of the OS
⭐ enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #376 , but the author did not authorize modifications on its fork before merge - so I forked his branch and pulled it into this PR.