Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR #376 #382

Merged
merged 15 commits into from
Apr 6, 2024
Merged

Updated PR #376 #382

merged 15 commits into from
Apr 6, 2024

Conversation

simonmicro
Copy link
Member

This PR is based on #376 , but the author did not authorize modifications on its fork before merge - so I forked his branch and pulled it into this PR.

@simonmicro simonmicro added ⭐ enhancement New feature or request src/osw-app This PR / issue impacts the current release of the OS labels Apr 6, 2024
@simonmicro simonmicro self-assigned this Apr 6, 2024
@simonmicro simonmicro force-pushed the PR_376/LorenzoSciaccaOrg_master branch from 5ee7be9 to 9a962f3 Compare April 6, 2024 08:05
Copy link
Member

@RuffaloLavoisier RuffaloLavoisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/apps/_experiments/OswAppWeather.cpp Outdated Show resolved Hide resolved
src/apps/_experiments/OswAppWeather.cpp Outdated Show resolved Hide resolved
src/apps/_experiments/OswAppWeather.cpp Outdated Show resolved Hide resolved
src/apps/_experiments/OswAppWeather.cpp Show resolved Hide resolved
@simonmicro simonmicro force-pushed the PR_376/LorenzoSciaccaOrg_master branch from 4802e96 to c6a07d5 Compare April 6, 2024 08:29
@simonmicro simonmicro added ✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished and removed ✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished labels Apr 6, 2024
@simonmicro
Copy link
Member Author

Nope, found multiple SEGFAULT-s in the emulator due to this app. I'll patch these first.

@simonmicro simonmicro added the ✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished label Apr 6, 2024
Lorenzosciacca and others added 15 commits April 6, 2024 11:30
+The OSW weather app is now supported also when using the emulator.
+Documentation update
Cleanup debug print
Errors and warnings
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
- out-of-memory reads
- use of incorrectly cached HAL reference
- underflow of size_t
- wrong signedness comparison
- botched load-from-file in emulator erro handling

Signed-off-by: simonmicro <simon@simonmicro.de>
@simonmicro simonmicro force-pushed the PR_376/LorenzoSciaccaOrg_master branch from 561f6df to 7fdd287 Compare April 6, 2024 09:30
@simonmicro simonmicro merged commit e800dbd into develop Apr 6, 2024
43 checks passed
@simonmicro simonmicro deleted the PR_376/LorenzoSciaccaOrg_master branch April 6, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished src/osw-app This PR / issue impacts the current release of the OS ⭐ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants