Use antialiased circles, arcs and lines #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor cleanups Avoid flickering and optimize new line drawing algorithm Use more floats (save 1k of Flash) Fix AA-circle quirk more float to go use hypotf Different ending for thick lines Try to optimize with trigonometric table. fine tune Optimize division of chunkHeight Optimized arc, better AA lower CPU freq for power savings Saves approx 50% during on time. disable cpufreq honor review Screen fill
One step to lua Make Twilight watchface with LUA support add drawArcAA and migrate OswAppWatchface Make LUA work with emulator
There was a problem hiding this comment.
Hi there 😄
Could you please split the PR into small pieces and request it? If there are many changes, it is difficult to check the review and potential influence. It is also possible to make and merge sub PR separately.
sample
main PR
- sub PR feature 1
- sub PR feature 2
|
Hi there back. Unfortunately no. You are free to take that code or not (and modify what you like). This code works for me, and I am pleased with it Cheers |
simonmicro
force-pushed
the
develop
branch
2 times, most recently
from
890efcf to
9478a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #396 (because this adds the aliasing?)
Use the anti alias feature on watchfaces:
Mix, Monotimer and Numerals