Update watchface_digital.cpp #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting an issue where if the step count was too low (or presumably too high) the centering would be incorrect. It should now be dynamic and tested up to a step count of 5 digits, as low as 1, to ensure centering works as expected.
|
numPositiveDigits could be useful as a helper somewhere, not sure where we could put it though |
uvwxy
requested changes
May 5, 2021
src/apps/main/watchface_digital.cpp
Outdated
| hal->gfx()->setTextSize(2); | ||
| hal->gfx()->setTextCursor(((220/2)-defaultFontXOffset(1, 2)), 210 - defaultFontYOffset(1, 2) / 2); | ||
| hal->gfx()->setTextCursor(120 - hal->gfx()->getTextOfsetColumns(width/2), 210 - defaultFontYOffset(1, 2) / 2); |
There was a problem hiding this comment.
better: setTextCenterAligned(), then we don't need the numPositiveDigits.
There was a problem hiding this comment.
Updated to use setTextCenterAligned and tested working great
Using setTextCenterAligned for center aligning the text
RuffaloLavoisier
pushed a commit
to RuffaloLavoisier/Ruffalo-OSW
that referenced
this pull request
Apr 27, 2022
…t-centering Update watchface_digital.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting an issue where if the step count was too low (or presumably too high) the centering would be incorrect. It should now be dynamic and tested up to a step count of 5 digits, as low as 1, to ensure centering works as expected.