Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteproc_get_mem could wrongly match on wrong name #374

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

tammyleino
Copy link
Collaborator

Modified remoteproc_get_mem to bound the name comparison by RPROC_MAX_NAME_LEN instead of the length of the incoming search string

Bound name comparison by RPROC_MAX_NAME_LEN instead of length of search string
Signed-off-by: Tammy Leino <tammy_leino@mentor.com>
@arnopo arnopo requested review from arnopo and edmooring April 15, 2022 07:22
lib/remoteproc/remoteproc.c Show resolved Hide resolved
@arnopo arnopo linked an issue Apr 15, 2022 that may be closed by this pull request
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that an earlier check constrains strlen(name) to < RPROC_MAX_NAME_LEN, this change makes things clearer.

@arnopo arnopo merged commit 0d75fa7 into OpenAMP:main Apr 20, 2022
@arnopo arnopo added this to the Release V2022.04 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remoteproc_get_mem could match on wrong memory region name
3 participants