Additional input parameter checks for APIs #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammyleino
force-pushed
the
openamp_355
branch
2 times, most recently
from
c1f7e2f
to
1381fbb
Compare
|
Discussion regarding these checks is greatly appreciated - some may be too stringent for all systems. |
tammyleino
force-pushed
the
openamp_355
branch
2 times, most recently
from
e0f10d0
to
9954479
Compare
edmooring
requested changes
Aug 6, 2022
arnopo
requested changes
Aug 17, 2022
lib/remoteproc/remoteproc.c
Outdated
|
|
||
| io = remoteproc_get_io_with_va(rproc, rsc_table); | ||
| if (rproc && rsc_table) | ||
| io = remoteproc_get_io_with_va(rproc, rsc_table); |
There was a problem hiding this comment.
what about?
if (!rproc || !rsc_table || ! rsc_size)
return -RPROC_EINVAL;
io = remoteproc_get_io_with_va(rproc, rsc_table);
if (!io)
return -RPROC_EINVAL;
There was a problem hiding this comment.
Sure, will change.
edmooring
approved these changes
Aug 29, 2022
tammyleino
force-pushed
the
openamp_355
branch
from
9954479
to
d7fe6c3
Compare
Added additional input parameter checks to APIs Signed-off-by: Tammy Leino <tammy_leino@mentor.com>
tammyleino
force-pushed
the
openamp_355
branch
from
d7fe6c3
to
eb3f097
Compare
arnopo
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional input parameter checks to APIs
Signed-off-by: Tammy Leino tammy_leino@mentor.com