Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/OpenAMP/open-amp/issues/455 #533

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

danmilea
Copy link
Collaborator

@danmilea danmilea commented Nov 6, 2023

The if (&rpc->ept) comparison will always evaluate as 'true', since rpc == &rpc->ept and rpc is previously checked to be valid.

This produces an error when building open-amp with gcc >= 13.

@arnopo arnopo linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit subject have to be updated

"service: rpmsg_rpc: fix build warning"

The reference to the github issue should not be part of the commit message, already referenced in the PR. I did the link between the issue and the PR in github

The if (&rpc->ept) comparison will always evaluate as 'true',
since rpc == &rpc->ept and rpc is previously checked to be valid.

This produces an error when building open-amp with gcc >= 13.

Signed-off-by: Dan Milea <dan.milea@windriver.com>
Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arnopo arnopo merged commit cce796d into OpenAMP:main Nov 21, 2023
3 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure - Ubuntu 22.10 / gcc-12
3 participants