V2024.05.0 release fixes #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the samples/subsys/ipc/openamp_rsc_table/ sample generates the
following warning:
[24/182] Building C object zephyr/CMakeFiles/zephyr.dir/lib/open-amp/resource_table.c.obj
In file included from /zephyrproject/zephyr/lib/open-amp/./resource_table.h:11,
from /zephyrproject/zephyr/lib/open-amp/resource_table.c:30:
/zephyrproject/modules/lib/open-amp/open-amp/lib/include/openamp/virtio.h:83:2:
warning: #warning "VIRTIO_DRIVER_SUPPORT and/or VIRTIO_DEVICE_SUPPORT should be defined" [-Wcpp]
83 | #warning "VIRTIO_DRIVER_SUPPORT and/or VIRTIO_DEVICE_SUPPORT should be defined"
| ^~~~~~~
The issue occurs because the project includes the virtio API while
VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT is only defined for
the open-amp library build.
Fix the warning by testing deprecated usage of VIRTIO_DRIVER_ONLY and
VIRTIO_DEVICE_ONLY but not under
#if !defined(VIRTIO_DRIVER_SUPPORT) && !defined(VIRTIO_DEVICE_SUPPORT)
condition.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
…RIVER The virtio.h header can be included by applications. In such cases, VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT, which are used to optimize the library, may not be defined in the application. Define default VIRTIO_ROLE_IS_DEVICE and VIRTIO_ROLE_IS_DRIVER macros that do not check for VIRTIO_DEVICE_SUPPORT or VIRTIO_DRIVER_SUPPORT if they are not defined. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
carlocaione
approved these changes
Jun 14, 2024
tnmysh
approved these changes
Jun 14, 2024
|
New issue found in Zephyr introduced in |
iuliana-prodan
approved these changes
Jun 26, 2024
carlocaione
approved these changes
Jun 27, 2024
This patch fixes the rpmsg_create_ept function passing the endpoint's private data that can be set by the application before the call of rpmsg_create_ept. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Set library version to 1.6.1 Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
|
Minor fix on coommit message subject to add "lib:" prefix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues were detected in Zephyr during CI when integrating the new release v2024.05.0:
The root cause is that the application can include the
virtio.hheader without defining VIRTIO_DRIVER_SUPPORT or VIRTIO_DEVICE_SUPPORT, which should not result in a warning or error.This pull request:
Fix also unreferenced
endpoint->privfield, found in Zephyr and introduced in9905d67