Refactor example code #12
Conversation
|
@TanmayShah-xilinx : could you confirm that the PR does not introduce regression on your platform? |
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| APP = echo_test | |||
| APP_OBJS = echo_test.o | |||
| APP_OBJS = echo_test.o ../common/common.o | |||
There was a problem hiding this comment.
Thanks for your patch.
We should include common.o in clean target as well.
So when we do make clean, it re-builds common.o as well.
or probably introduce new target (distclean), that will remove common.o as well. clean will only remove local directory *.o and distclean will remove all dependencies as well such as common.o. I am fine with either approach.
Thanks.
There was a problem hiding this comment.
I'm not sure how the 'clean' option would interact when one wanted only to clean the current project but I'd assume that would be rare anyway. Easy enough to just use APP_OBJS as the rm targets.
Fixing out of tree builds (or using CMake or similar) would fix all that, but that would be a task for another day :)
@arnopo I verified matrix multiply and proxy app demo. It is working fine without introducing regressions on zcu102 qemu platform. I have some comments, but apart from that it looks good to me. |
Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Andrew Davis <afd@ti.com>
Make matrix_print() into a common function and use it for both printing the input and output matrices. Also add 3 wide padding so the output looks more like a table when the numbers are not all the same length. Signed-off-by: Andrew Davis <afd@ti.com>
Usually considered bad practice and the code is more readable without. Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Andrew Davis <afd@ti.com>
Signed-off-by: Andrew Davis <afd@ti.com>
The file should be closed when returning from this function in the error path. Fix this here. Signed-off-by: Andrew Davis <afd@ti.com>
This helps make these example files shorter and less intimidating for new users. Useful when trying to showcase OpenAMP to new users and teams.