Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zynqmp DTS: Update for v6.6 kernel #47

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

wmamills
Copy link
Collaborator

@wmamills wmamills commented Jul 2, 2024

No real update was needed for v6.6 but update the names and comments to make things more clear. Delete the #if 0 stuff in the bare-metal dtso.

Looking ahead this configuration looks compatible and still needed for v6.6 through at least v6.10 (as of v6.10-rc6).

@wmamills wmamills requested a review from tnmysh July 2, 2024 11:56
@wmamills
Copy link
Collaborator Author

wmamills commented Jul 2, 2024

@arnopo FYI on this one as it is all Xilinx. I am using upstream DTBs for ST this release as the audio issue is gone for v6.6.
(The ST DTB stuff was never in main; it was only in the v2023.10 branch)

@wmamills
Copy link
Collaborator Author

wmamills commented Jul 2, 2024

Actually runtime tests of this are failing. I can run rpmsg_multi_services (Zephyr 3.5 & 3.6) and kernel 6.6 with the old dtb and it works OK. When I switch to this new dtb I get no rpmsg activity.

I will be looking at this more closely.

No real update was needed for v6.6 but update the names and comments to
make things more clear.  Delete the #if 0 stuff in the bare-metal dtso.

Looking ahead this configuration looks compatible and still needed for
v6.6 through at least v6.10 (as of v6.10-rc6).

Signed-off-by: Bill Mills <bill.mills@linaro.org>
@wmamills
Copy link
Collaborator Author

wmamills commented Jul 4, 2024

@tnmysh disregard the comment above. The code does work as is and this PR is good to go.
Please review as soon as you can.

(I had accidentally used the version built against v6.10-rc6. It needs adjustment when we update as many underscores have been changed to dash (zynqmp_ipi -> zynqmp-ipi) It works fine when used against v6.6.x ).

Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wmamills wmamills merged commit aa4163b into OpenAMP:main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants