Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Modify README formatting #9

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

tnmysh
Copy link
Collaborator

@tnmysh tnmysh commented Dec 12, 2022

Current README.md contains many titles with # prefix of each line. It generates lots of indexes when these README files are linked in openamp-docs repo.
Remove redundant # prefix. Only keep it for demo title, compilation steps and demo run steps. This way, openamp-docs generates minimal index in table of content.

Also re-edit README.md files for better presentation.

Signed-off-by: Tanmay Shah tanmay.shah@amd.com

examples/linux/rpmsg-echo-test/README.md Outdated Show resolved Hide resolved
examples/linux/rpmsg-echo-test/README.md Outdated Show resolved Hide resolved
examples/linux/rpmsg-echo-test/README.md Outdated Show resolved Hide resolved
* https://github.com/OpenAMP/open-amp#example-to-compile-zynq-ultrascale-mpsoc-r5-genericbaremetal-remote
* RPU firmware elf file is expected in sdk at path: /lib/firmware/
* This build step needs Xilinx Vendor specific toolchain xsdb
* Instructions to compile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you change the hierarchy here, seems strange to have the bullets below at same level.
suggestion s/* /## /

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 3 spaces instead of two spaces. Also, adding ## generates heading index in sphinx documentation. I am trying to avoid it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. So, when I change hierarchy, I need to move indentation as well from the title. I will modify formatting for each README.md and keep 2 space of indentation and indent bullets and subtitles as required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to create subtitle line i.e. starts with ## and Bullet line i.e. starts with * at the same indent level for sphinx to generate Bullet point. Otherwise I don't see Bullet point. So, I will keep both at same indent level.

examples/linux/rpmsg-echo-test/README.md Outdated Show resolved Hide resolved
examples/linux/rpmsg-mat-mul/README.md Show resolved Hide resolved
Copy link
Collaborator

@wmamills wmamills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Arnaud comments and added a couple myself.

examples/linux/rpmsg-echo-test/README.md Outdated Show resolved Hide resolved

## How to run on zcu102 board/QEMU:
Assume all the binaries are zcu102 board specific.
https://github.com/OpenAMP/open-amp#example-to-compile-zynq-ultrascale-mpsoc-r5-genericbaremetal-remote
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to line in README.md not to project front page.
This apples everywhere you do this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Current README.md contains many titles with # prefix of each line.
It generates lots of indexes when these README files are linked in
openamp-docs repo.
Remove redundant # prefix. Only keep it for demo title, compilation steps
and demo run steps. This way, openamp-docs generates minimal index in table
of content.

Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
@tnmysh tnmysh requested review from arnopo and wmamills and removed request for arnopo December 13, 2022 06:03
Copy link
Collaborator

@wmamills wmamills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good enough for now.
This has Xilinx everywhere and not AMD Xilinx.
If they need that changed it can be another PR

@arnopo arnopo merged commit 1e91a36 into OpenAMP:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants