Add phplint package (#15054)

OpenAPITools · Mar 29, 2023 · dd16e22 · dd16e22
1 parent a4540fe
commit dd16e22
Show file tree

Hide file tree

Showing 10 changed files with 73 additions and 4 deletions.
diff --git a/...i-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java b/...i-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java
@@ -115,6 +115,7 @@ public void processOpts() {
         supportingFiles.add(new SupportingFile("phpunit.xml.mustache", "", "phpunit.xml.dist"));
         supportingFiles.add(new SupportingFile(".travis.yml", "", ".travis.yml"));
         supportingFiles.add(new SupportingFile(".php-cs-fixer.dist.php", "", ".php-cs-fixer.dist.php"));
+        supportingFiles.add(new SupportingFile(".phplint.mustache", "", ".phplint.yml"));
         supportingFiles.add(new SupportingFile("git_push.sh.mustache", "", "git_push.sh"));
     }
 }
diff --git a/modules/openapi-generator/src/main/resources/php-nextgen/.phplint.mustache b/modules/openapi-generator/src/main/resources/php-nextgen/.phplint.mustache
@@ -0,0 +1,11 @@
+path:
+  - ./{{srcBasePath}}
+  - ./{{testBasePath}}
+jobs: 10
+extensions:
+  - php
+exclude:
+  - vendor
+warning: true
+memory-limit: -1
+no-cache: true
diff --git a/modules/openapi-generator/src/main/resources/php-nextgen/composer.mustache b/modules/openapi-generator/src/main/resources/php-nextgen/composer.mustache
@@ -32,13 +32,20 @@
         "guzzlehttp/psr7": "^2.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.0",
-        "friendsofphp/php-cs-fixer": "^3.5"
+        "friendsofphp/php-cs-fixer": "^3.5",
+        "overtrue/phplint": "^9.0",
+        "phpunit/phpunit": "^9.0"
     },
     "autoload": {
         "psr-4": { "{{escapedInvokerPackage}}\\" : "{{srcBasePath}}/" }
     },
     "autoload-dev": {
         "psr-4": { "{{escapedInvokerPackage}}\\Test\\" : "{{testBasePath}}/" }
+    },
+    "scripts": {
+        "test": [
+            "@phplint"
+        ],
+        "phplint": "phplint"
     }
 }
diff --git a/modules/openapi-generator/src/main/resources/php-nextgen/gitignore b/modules/openapi-generator/src/main/resources/php-nextgen/gitignore
@@ -13,3 +13,6 @@ composer.phar
 
 # PHPUnit cache
 .phpunit.result.cache
+
+# PHPLint cache
+build/phplint.cache
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/.gitignore b/samples/client/petstore/php-nextgen/OpenAPIClient-php/.gitignore
@@ -13,3 +13,6 @@ composer.phar
 
 # PHPUnit cache
 .phpunit.result.cache
+
+# PHPLint cache
+build/phplint.cache
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/.openapi-generator/FILES b/samples/client/petstore/php-nextgen/OpenAPIClient-php/.openapi-generator/FILES
@@ -1,5 +1,6 @@
 .gitignore
 .php-cs-fixer.dist.php
+.phplint.yml
 .travis.yml
 README.md
 composer.json

diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/.phplint.dist.yml b/samples/client/petstore/php-nextgen/OpenAPIClient-php/.phplint.dist.yml
@@ -0,0 +1,12 @@
+path:
+  - ./lib
+  - ./test
+  - ./tests
+jobs: 10
+extensions:
+  - php
+exclude:
+  - vendor
+warning: true
+memory-limit: -1
+no-cache: true
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/.phplint.yml b/samples/client/petstore/php-nextgen/OpenAPIClient-php/.phplint.yml
@@ -0,0 +1,11 @@
+path:
+  - ./lib
+  - ./test
+jobs: 10
+extensions:
+  - php
+exclude:
+  - vendor
+warning: true
+memory-limit: -1
+no-cache: true
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/composer.json b/samples/client/petstore/php-nextgen/OpenAPIClient-php/composer.json
@@ -26,13 +26,20 @@
         "guzzlehttp/psr7": "^2.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.0",
-        "friendsofphp/php-cs-fixer": "^3.5"
+        "friendsofphp/php-cs-fixer": "^3.5",
+        "overtrue/phplint": "^9.0",
+        "phpunit/phpunit": "^9.0"
     },
     "autoload": {
         "psr-4": { "OpenAPI\\Client\\" : "lib/" }
     },
     "autoload-dev": {
         "psr-4": { "OpenAPI\\Client\\Test\\" : "test/" }
+    },
+    "scripts": {
+        "test": [
+            "@phplint"
+        ],
+        "phplint": "phplint"
     }
 }
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/pom.xml b/samples/client/petstore/php-nextgen/OpenAPIClient-php/pom.xml
@@ -39,6 +39,19 @@
                             </arguments>
                         </configuration>
                     </execution>
+                    <execution>
+                        <id>check-php-syntax</id>
+                        <phase>integration-test</phase>
+                        <goals>
+                            <goal>exec</goal>
+                        </goals>
+                        <configuration>
+                            <executable>vendor/bin/phplint</executable>
+                            <arguments>
+                                <argument>--configuration=phplint.dist.yml</argument>
+                            </arguments>
+                        </configuration>
+                    </execution>
                     <execution>
                         <id>bundle-test</id>
                         <phase>integration-test</phase>