[dart-dio-next] [BUG] Import mappings are not working

[HerrNiklasRaab]

Before reading the issue, the following two things are important:

• I am supporting fixing this issue with 50€
• I know that there is the option "dateLibrary: timemachine", but I need to solve it using "import-mappings" because of another reason I don't want to go into here (which should be possible, because I was already able to set up below use case in the backend).

I am running openapi-generator with the following command:

openapi-generator generate -g dart-dio-next \
-i ./api/_config/specs/backend-functional.yml \
-o ./api/backend-api \
-c ./api/_config/specs/backend-functional-config.yml

with the this configuration:

additionalProperties:
  pubName: backend_api
typeMappings:
  object: dynamic
  JsonObject: dynamic
  LocalDate: LocalDate
importMappings:
  LocalDate: "package:time_machine/time_machine.dart"

with this yaml:

CronRunConfiguration:
  properties:
    fakeDate:
      $ref: "#/components/schemas/LocalDate"

LocalDate:
  type: object

which generates the following code:

//
// AUTO-GENERATED FILE, DO NOT MODIFY!
//

import 'package:built_collection/built_collection.dart';
import 'package:backend_api/src/model/local_date.dart'; // Wrong import, expected: "package:time_machine/time_machine.dart"
import 'package:built_value/built_value.dart';
import 'package:built_value/serializer.dart';

part 'cron_run_configuration.g.dart';

/// CronRunConfiguration
///
/// Properties:
/// * [fakeDate] 
/// * [runCronFor] 
abstract class CronRunConfiguration implements Built<CronRunConfiguration, CronRunConfigurationBuilder> {
    @BuiltValueField(wireName: r'fakeDate')
    LocalDate? get fakeDate;

// ... The rest of the file is not important

what I would have expected is the following:

//
// AUTO-GENERATED FILE, DO NOT MODIFY!
//

import 'package:built_collection/built_collection.dart';
import 'package:time_machine/time_machine.dart'; // This is the important line
import 'package:built_value/built_value.dart';
import 'package:built_value/serializer.dart';

part 'cron_run_configuration.g.dart';

/// CronRunConfiguration
///
/// Properties:
/// * [fakeDate] 
/// * [runCronFor] 
abstract class CronRunConfiguration implements Built<CronRunConfiguration, CronRunConfigurationBuilder> {
    @BuiltValueField(wireName: r'fakeDate')
    LocalDate? get fakeDate;

// ... The rest of the file is not important

cc @kuhnroyal @wing328 Can you reproduce?

[kuhnroyal]

I added a draft PR, give it a try when you have time.

[HerrNiklasRaab]

Hey @kuhnroyal,

thanks for the PR, it almost works. Now I get the correct imports!

Unfortunately, I still get a compiler error, because the type LocalDate doesn't have the method "replace" as it's not a model that is generated using built_value:

Here is the respective mustache:

In my opinion, we have two options:

1. When using types from import-mappings always default to not making it a model
2. Introducing a flag like in Java called "--language-specific-primitives=LocalDate". Whenever a type is passed to this flag, it's considered to me not a model.

Don't know which one is better :)

[HerrNiklasRaab]

@kuhnroyal Increasing to 100 € if fixed until So, 17.Okt

[kuhnroyal]

Updated the PR

[HerrNiklasRaab]

Working like charm, thanks :) Waiting for your PayPal address, so that I can send you the money, once the PR is merged.

[kuhnroyal]

@HerrNiklasRaab Check the PR commit for the committer email.

[HerrNiklasRaab]

@kuhnroyal Sent the money, thanks for your help!