Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart][dio] Respect import-mappings parameter #10528

Merged

Conversation

kuhnroyal
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

* first check import mappings before defaulting to model import
* respect primitive types when generating serializes, these can still be models if passed via generator args
@kuhnroyal kuhnroyal force-pushed the dart-dio/respect-import-mapping branch from 4e78d73 to 4b16589 Compare October 10, 2021 17:26
@kuhnroyal kuhnroyal marked this pull request as ready for review October 12, 2021 19:31
@kuhnroyal
Copy link
Contributor Author

CC @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@ahmednfwela
Copy link
Contributor

will this allow importing types from external libraries?

@ahmednfwela
Copy link
Contributor

also we need a way to modify the generated pubspec.yaml based on the referenced libraries

@kuhnroyal
Copy link
Contributor Author

It does, but I think if you need a custom library in the pubspec, you should probably use a custom template for that file.

@wing328 wing328 added this to the 5.3.0 milestone Oct 13, 2021
@wing328 wing328 merged commit 34f475f into OpenAPITools:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dart-dio-next] [BUG] Import mappings are not working
5 participants