Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][kotlin-spring] Wildcard imports in generated Kotlin classes #14652

Closed
volsusdev opened this issue Feb 9, 2023 · 4 comments
Closed

[BUG][kotlin-spring] Wildcard imports in generated Kotlin classes #14652

volsusdev opened this issue Feb 9, 2023 · 4 comments
Labels
Issue: Bug

Comments

@volsusdev
Copy link
Contributor

volsusdev commented Feb 9, 2023 •
edited
Loading

Hi @parenko,

what was the reason for introducing wildcard imports to [kotlin-spring] with one of your last commits (cffe2d0)?
We now have the issue that it is not possible anymore to use ktlint for linting the generated code.

Bildschirmfoto 2023-02-09 um 09 05 19

openapi-generator version

6.3.0

Related issues/PRs

#14369

Suggest a fix

If there is no problem with single class imports in this case I would create a PR to change this back for javax.validation.constraints imports.
@volsusdev volsusdev changed the title [kotlin-spring] Description [kotlin-spring] Remove wildcard imports from generated Kotlin classes Feb 9, 2023
@volsusdev volsusdev changed the title [kotlin-spring] Remove wildcard imports from generated Kotlin classes [kotlin-spring] Wildcard imports in generated Kotlin classes Feb 9, 2023
@volsusdev volsusdev changed the title [kotlin-spring] Wildcard imports in generated Kotlin classes [BUG][kotlin-spring] Wildcard imports in generated Kotlin classes Feb 9, 2023
@parenko
Copy link
Contributor

parenko commented Feb 9, 2023

As far as I can remember there was a class that was in a different place in Jakarta. But I don't know which ones right now. Feel free to change.

@volsusdev
Copy link
Contributor Author

Thanks, then I will make a suggestion with single class imports but with your {{javaxPackage}} placeholder.

volsusdev added a commit to volsusdev/openapi-generator-fork that referenced this issue Feb 28, 2023
@volsusdev
[Kotlin-Spring] Remove wildcard imports from mustache templates [Open…
9b58b57 
…APITools#14652]
volsusdev added a commit to volsusdev/openapi-generator-fork that referenced this issue Feb 28, 2023
@volsusdev
[Kotlin-Spring] Update sample files [OpenAPITools#14652]
144f8bc
@volsusdev
Copy link
Contributor Author

I've opened a PR for this: #14899

4brunu pushed a commit that referenced this issue Mar 7, 2023
@volsusdev
[Kotlin-Spring] Remove wildcard imports from mustache templates [#14652…
c81ff58 
…] (#14899)

* [Kotlin-Spring] Remove wildcard imports from mustache templates [#14652]

* [Kotlin-Spring] Update sample files [#14652]
@volsusdev
Copy link
Contributor Author

fyi: Fix was merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parenko @volsusdev