Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Python][Python-Flask] packageName dots are not replaced to slashes #1899

Closed
4 tasks done
Fjolnir-Dvorak opened this issue Jan 12, 2019 · 3 comments
Closed
4 tasks done

Comments

@Fjolnir-Dvorak
Copy link
Contributor

Fjolnir-Dvorak commented Jan 12, 2019

openapi-generator version

4.0.0-SNAPSHOT

Description

#####Bug description
Client:
PythonClientCodegen.java line 250-269
PythonFlaskConnectionServerCodegen.java line 47-57
new SupportingFile("asdf.mustache", packageName, "asdf.py"));
instead of
new SupportingFile("asdf.mustache", packageName.replace(".", "/"), "asdf.py"));

Related issues/PRs

#1853 It has to do with this issue because packageName should not exist. Instead invoker-package should be used (as far as I understand the documentation)
#1302 exactly this issue but only reported for the client

Suggest a fix

Pull-request already in work

@Fjolnir-Dvorak Fjolnir-Dvorak changed the title [BUG] [Python][Python-Flask] [BUG] [Python][Python-Flask] packageName dots are not replaced to slashes Jan 12, 2019
@svenpanne
Copy link
Contributor

I've just seen this issue, and I've already submitted a patch for the client part: #2016 I will have a look at the server part soon...

@svenpanne
Copy link
Contributor

Fix for server part in #2041.

@Fjolnir-Dvorak
Copy link
Contributor Author

Fjolnir-Dvorak commented Feb 25, 2019

Oh, thank you. I finally thought about this issue again and wanted to create a pull request. I assume I will wait until that patch is applied which happened already on 2019-02-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants