[BUG][Python] "sub-module" definition in packageName does not work

[tomghyselinck]

Description

We define "packageName": "myapi.rest.client" in the config file for the python generator.
This is because we want our REST API to de a submodule of the myapi.

The generated code does not give us the expected code layout.

openapi-generator version

I used OpenAPI generator CLI version 4.0.0-SNAPSHOT:
https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-cli/4.0.0-SNAPSHOT/openapi-generator-cli-4.0.0-20181210.103357-85.jar

OpenAPI declaration file content or url

python-sub-module.yaml:

openapi: '3.0.1'
info:
        title: Test REST API
        version: "1.0"
servers:
- url: /
paths:
        /data:
                get:
                        summary: Get the Remote Data
                        responses:
                                '200':
                                        description: Remote Object
                                        content:
                                                application/json:
                                                        schema:
                                                                properties:
                                                                        data:
                                                                                type: string

Command line used for generation

java -jar openapi-generator-cli-4.x.jar generate -i ./python-sub-module.yaml -g python -o ./client/python/ -c ./config/python.json

Steps to reproduce

python-sub-module.sh:

#!/bin/sh
mkdir -p config
cat >config/python.json <<-CONFIG
{
        "packageName": "myapi.rest.client",
        "projectName": "myapi-rest-client"
}
CONFIG

rm -rf client/python/
java -jar openapi-generator-cli-4.x.jar generate -i ./python-sub-module.yaml -g python -o ./client/python/ -c ./config/python.json

tom@localhost:~/issues$ ./python-sub-module.sh
tom@localhost:~/issues$ tree -aAC client/python/
client/python/
├── docs
│   └── DefaultApi.md
├── .gitignore
├── git_push.sh
├── myapi
│   └── rest
│       └── client
│           └── api
│               └── default_api.py
├── myapi.rest.client
│   ├── api
│   │   └── __init__.py
│   ├── api_client.py
│   ├── configuration.py
│   ├── __init__.py
│   ├── models
│   │   └── __init__.py
│   └── rest.py
├── .openapi-generator
│   └── VERSION
├── .openapi-generator-ignore
├── README.md
├── requirements.txt
├── setup.py
├── test
│   ├── __init__.py
│   └── test_default_api.py
├── test-requirements.txt
├── tox.ini
└── .travis.yml

10 directories, 20 files

Related issues/PRs

• [Python] Support for package hierarchy  #1302
• [BUG] [Python][Python-Flask] packageName dots are not replaced to slashes #1899

Suggest a fix

Fixes in progress:

• [python] [bug] Fixed handling of dotted module names #2016
• [python-flask] [python-aiohttp] [bug] Fixed handling of dotted module names #2041

[auto-labeler]

Thanks for opening this issue! I have applied any relevant labels.

[adrpp]

Hello,

btw this affects actual stable as well.

generator version: openapi-generator-cli-3.3.4
generator: python-flask
after generation, it looks like @tomghyselinck reported.

wrong placed files / dirs:

• "base_model_.py" is placed wrong
• "openapi/openapi.yaml"
• "encoder.py"
• "util.py"

Rgds,
Adrian

[tomghyselinck]

A similar issue has been reported in #1899

[tomghyselinck]

This seems to work fine with the latest SNAPSHOT versions (with #2016 and #2041 integrated)