[BUG] [PYTHON] generateSourceCodeOnly value is not checked properly

[qbedard]

Description

This is the code from PythonClientCodegen.java that checks the config property for generateSourceCodeOnly:

Boolean generateSourceCodeOnly = false;
if (additionalProperties.containsKey(CodegenConstants.SOURCECODEONLY_GENERATION)) {
    generateSourceCodeOnly = true;
}

It's pretty obvious that when the config json includes:

{
    "generateSourceCodeOnly": false
}

...the above code will incorrectly set generateSourceCodeOnly to true.

openapi-generator version

4.0.0

OpenAPI declaration file content or url

< any valid declaration file >

Command line used for generation

openapi-generator generate -i openapi.yaml -g python -c config.json

Steps to reproduce

Run the above command on a valid declaration file with generateSourceCodeOnly set to false in the config.json.

Suggest a fix

Actually set the value to what's in the config.

Boolean generateSourceCodeOnly = false;
if (additionalProperties.containsKey(CodegenConstants.SOURCECODEONLY_GENERATION)) {
    generateSourceCodeOnly = convertPropertyToBoolean(CodegenConstants.SOURCECODEONLY_GENERATION);
}

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

I think it should be fixed by #2015. Please give the latest master a try.

Closing this for the time being. We'll reopen it if it's still an issue.

[qbedard]

Searched but still missed it. Thanks.

[wing328]

if (additionalProperties.containsKey(CodegenConstants.SOURCECODEONLY_GENERATION)) {
generateSourceCodeOnly = convertPropertyToBoolean(CodegenConstants.SOURCECODEONLY_GENERATION);
}

Do you mind filing a PR with your suggested fix if it's still an issue?

[qbedard]

Nah, #2015 fixed it.