Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] [bug]Use actual value of generateSourceCodeOnly #2015

Merged
merged 1 commit into from
Feb 6, 2019
Merged

[python] [bug]Use actual value of generateSourceCodeOnly #2015

merged 1 commit into from
Feb 6, 2019

Conversation

svenpanne
Copy link
Contributor

@svenpanne svenpanne commented Jan 29, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. (Irrelevant point, Travis CI checked the PR in my fork.)
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The generateSourceCodeOnly was implicitly always true, regardless of its actual value. This has been fixed.

@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess

@svenpanne svenpanne changed the title Use actual value of generateSourceCodeOnly in python generator. [python] [bug]Use actual value of generateSourceCodeOnly Jan 29, 2019
@rienafairefr
Copy link
Contributor

Looks good to me.
I added the generateSourceCodeOnly feature, It was supposed to be a boolean flag (-DgenerateSourceCodeOnly= or -DgenerateSourceCodeOnly means generateSourceCodeOnly true, and its absence mean false). supporting -DgenerateSourceCodeOnly=<boolean_value> is good and is more consistent with other options, 👍

@kenjones-cisco
Copy link
Contributor

LGTM! 👍

@wing328
Copy link
Member

wing328 commented Feb 6, 2019

@rienafairefr @kenjones-cisco thanks for reviewing the change.\

@svenpanne thanks for your contribution.

@wing328 wing328 merged commit dd3e6c6 into OpenAPITools:master Feb 6, 2019
@wing328 wing328 added this to the 4.0.0 milestone Feb 6, 2019
@svenpanne svenpanne deleted the fix-source-code-only branch February 11, 2019 07:55
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants