Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libcurl CMake adaptations #10249

Merged
merged 5 commits into from
Aug 27, 2021
Merged

Conversation

ahmedyarub
Copy link
Contributor

@zhemant @ityuhui @michelealbano

Remove default build type and library shared flag
Add OpenSSL using imported targets on supported CMake versions
PreTarget and PostTarget scripts where the former one is used to add new source files and run additional find_package() commands, and the latter can be used to add optional components such as whether to include building examples and also to customize the installation command.

Related PR which I'm going to close in favor of this later: kubernetes-client/c#75

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Remove default build type
Add OpenSSL using imported targets
PreTarget and PostTarget scripts
Do not build as shared by default
Fix typos
Correctly add target link libraries
Copy link
Contributor

@ityuhui ityuhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is OK to me. @wing328

Thank you @ahmedyarub !

@wing328 wing328 added this to the 5.3.0 milestone Aug 27, 2021
@wing328 wing328 merged commit 8818bf2 into OpenAPITools:master Aug 27, 2021
@ahmedyarub ahmedyarub deleted the ay/adapt_curl_cmake branch August 29, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants