Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] fix for invalid code being generated for enums #10328

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

mawis
Copy link
Contributor

@mawis mawis commented Sep 5, 2021

Elm code generator produces invalid elm code if there are enums in the OpenAPI specification. As described in #8343 the problem is the missing encoder/decoder for the enum field in the encoder/decoder of the structure. With this patch the encoders/decoders are added as required.

@eriktim

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

As described in
OpenAPITools#8343 invalid
code was generated when the OpenAPI uses enums. With this the
decoders/encoders are called at the correct place.
@wing328
Copy link
Member

wing328 commented Sep 8, 2021

I've not tested it locally. It looks to be a good fix so I'll include this in the upcoming v5.3.0 release. Thanks for the PR.

@wing328 wing328 merged commit 2640c36 into OpenAPITools:master Sep 8, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants