Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version management, update dependencies, remove unused dependencies #10544

Merged
merged 30 commits into from
Oct 13, 2021

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 6, 2021

Goals of this PR:

  • general improvement of version management
    • centralise dependency management in main pom.xml for dependencies/plugins that are used in more than one module
  • remove dependencies and plugins that exist in classpath in more than one version
  • upgrade some dependencies to newer versions that are java 11+ ready

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@agilob
Copy link
Contributor Author

agilob commented Oct 6, 2021

Im going to check for unused dependencies now using mvn dependency:analyze

and found these:

WARNING] Unused declared dependencies found:
[WARNING]    org.springframework.boot:spring-boot-starter-web:jar:2.2.9.RELEASE:compile
[WARNING]    com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.10.2:compile
[WARNING]    com.fasterxml.jackson.core:jackson-core:jar:2.10.2:compile
[WARNING]    org.springframework.boot:spring-boot-starter-test:jar:2.2.9.RELEASE:test
[WARNING]    org.springframework.boot:spring-boot-test:jar:2.2.9.RELEASE:test
[WARNING]    org.hamcrest:java-hamcrest:jar:2.0.0.0:test

each will be removed in separate commit for easy reversal, but pushed together

@agilob
Copy link
Contributor Author

agilob commented Oct 6, 2021

org.springframework.boot:spring-boot-starter-web:jar:2.2.9.RELEASE:compile

mvn plugin reports this as unused, false positive :(

@agilob agilob changed the title WIP Improving version management Improve version management, update dependencies, remove unused dependencies Oct 6, 2021
@agilob
Copy link
Contributor Author

agilob commented Oct 6, 2021

@wing328 @jimschubert I think that's it 👍

@wing328
Copy link
Member

wing328 commented Oct 13, 2021

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 5.3.0 milestone Oct 13, 2021
@wing328 wing328 merged commit 45336be into OpenAPITools:master Oct 13, 2021
@agilob agilob deleted the version-management branch October 13, 2021 07:17
@agilob agilob restored the version-management branch October 13, 2021 11:49
parenko added a commit to parenko/openapi-generator that referenced this pull request May 20, 2024
Was introduced with OpenAPITools#7587 could be removed with OpenAPITools#10544
wing328 pushed a commit that referenced this pull request May 21, 2024
…18576)

* Added support for <inputSpec/> arguments of JAR URLs.
E.g., jar:jar-specific-uri!/spec.yml.

* Resolve and search COMPILE dependencies for inputSpec resource.

* Added test cases for openapi-generator-maven-plugin:generate input
specifications:

* URLs of the form jar:jar-specific-uri!/spec.yaml

* Resources on the compilation classpath

in addition to the existing FILE test case.

* Check for inputSpecFile existence

else it is a remote URL && url is not empty

* replaced deprecated usage

* use Unix separators when on win-os

* example with jar inputSpec

* Comment not required anymore

Was introduced with #7587 could be removed with #10544

* referenced same maven version

these artifacts are referenced by same ${project.version} in https://github.com/apache/maven/blob/master/pom.xml

* updating maven dependencies to 3.9.6

---------

Co-authored-by: Allen D. Ball <ball@hcf.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants