Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-rest-sdk-client] Serialize boolean parameters as true/false instead of 1/0 #10554

Merged
merged 12 commits into from
Oct 13, 2021

Conversation

shayan-eftekhari
Copy link
Contributor

fix #10553

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@MartinDelille
Copy link
Contributor

Could you precise the generator in the PR title?

@shayan-eftekhari shayan-eftekhari changed the title Serialize boolean parameters as true/false instead of 1/0 [cpp-rest-sdk-client] Serialize boolean parameters as true/false instead of 1/0 Oct 7, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 13, 2021
@wing328 wing328 merged commit 843e572 into OpenAPITools:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants