Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't send just " " in body, send an empty string #10561

Merged

Conversation

mickaelmagniez
Copy link
Contributor

Fix #10560

Change the default body sent from " " (space character) to empty body.

Because some backends (for example akka-http) failed to parse it as json.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cchafer

@wing328
Copy link
Member

wing328 commented Oct 9, 2021

cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

@chameleon82
Copy link
Contributor

@wing328 sorry, don't have permissions to approve this PR.
PR Looks good to me

@wing328
Copy link
Member

wing328 commented Oct 9, 2021

@chameleon82 thanks for the quick review.

@mickaelmagniez thanks for the PR.

@wing328 wing328 merged commit ba55332 into OpenAPITools:master Oct 9, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][scala-http-client] Default body should not be a single space
3 participants