Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] fix 'mixed' invalid for settype() #10576

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

NickUfer
Copy link
Contributor

@NickUfer NickUfer commented Oct 10, 2021

Fixes: #10575

Adds an if statement in ObjectSerializer#deserialize for the mixed openapi type which resolves the correct class for the supplied data.

@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Signed-off-by: Nick Ufer <nick@ufer.dev>
@wing328
Copy link
Member

wing328 commented Oct 12, 2021

LGTM but I've not tested it locally.

@wing328 wing328 merged commit 80c3a0e into OpenAPITools:master Oct 12, 2021
@NickUfer NickUfer mentioned this pull request Oct 28, 2021
6 tasks
@NickUfer NickUfer deleted the php_fix_mixed_type branch December 9, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][PHP] settype(): Argument #2 ($type) must be a valid type
2 participants