Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotlin enum default value #10592

Merged

Conversation

etremblay
Copy link
Contributor

@etremblay etremblay commented Oct 13, 2021

Everything is described in the Issue #10591

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) heart, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@4brunu
Copy link
Contributor

4brunu commented Oct 13, 2021

Hey, thanks for creating this PR.
Could you please run the following commands and commit the changes?

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

Thanks

@4brunu
Copy link
Contributor

4brunu commented Oct 13, 2021

This didn't change the code in the sample projects.
Did you tested this in any project that changes the code?

@etremblay
Copy link
Contributor Author

etremblay commented Oct 13, 2021

This didn't change the code in the sample projects. Did you tested this in any project that changes the code?

I think there is no sample with that test case. I tested it with a unit test and a manual code generation.

Are we allowed to add test cases in "official" samples ?

Edit just found how to register my test yaml in bin/configs/

@etremblay
Copy link
Contributor Author

Here is the interesting file : samples/client/petstore/kotlin-enum-default-value/src/main/kotlin/org/openapitools/client/models/ModelWithEnumPropertyHavingDefault.kt

@4brunu
Copy link
Contributor

4brunu commented Oct 14, 2021

Thanks, looks good to me 👍

@wing328 wing328 added this to the 5.3.0 milestone Oct 16, 2021
@wing328 wing328 merged commit 11bfc66 into OpenAPITools:master Oct 16, 2021
@wing328 wing328 changed the title Issue #10591 kotlin enum defaultValue Fix kotlin enum defaultValue Oct 16, 2021
@wing328 wing328 changed the title Fix kotlin enum defaultValue Fix kotlin enum default value Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants