Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try-with-resources to unclosed streams #10640

Closed
wants to merge 1 commit into from

Conversation

artwo
Copy link
Contributor

@artwo artwo commented Oct 19, 2021

This PR improves the handling of input and output streams by using the try-with-resources statement to ensure that they are closed. There is a correction on how the try-with-resources is used with multiple streams which is based in this documentation.

The PR is meant to fix the remaining sonarcloud issues of #788.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@artwo artwo closed this Oct 19, 2021
@artwo artwo deleted the closing-open-streams branch October 19, 2021 20:57
@artwo
Copy link
Contributor Author

artwo commented Oct 19, 2021

Sorry, I submitted the code changes with the wrong GH account. I would like them to be related to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant