Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSingleRequestParameter should mark parameter optional if all properties are optional #11135

Merged
merged 2 commits into from
Dec 24, 2021
Merged

useSingleRequestParameter should mark parameter optional if all properties are optional #11135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4023ded
useSingleRequestParameter should mark parameter optional if all prope…
davidgamero Dec 13, 2021
0bdac60
update samples
davidgamero Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-fetch/apis.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ export class {{classname}} extends runtime.BaseAPI {
}
{{/useSingleRequestParameter}}
{{#useSingleRequestParameter}}
async {{nickname}}({{#allParams.0}}requestParameters: {{#prefixParameterInterfaces}}{{classname}}{{/prefixParameterInterfaces}}{{operationIdCamelCase}}Request, {{/allParams.0}}initOverrides?: RequestInit): Promise<{{{returnType}}}{{^returnType}}void{{/returnType}}> {
async {{nickname}}({{#allParams.0}}requestParameters: {{#prefixParameterInterfaces}}{{classname}}{{/prefixParameterInterfaces}}{{operationIdCamelCase}}Request{{^hasRequiredParams}} = {}{{/hasRequiredParams}}, {{/allParams.0}}initOverrides?: RequestInit): Promise<{{{returnType}}}{{^returnType}}void{{/returnType}}> {
{{#returnType}}
const response = await this.{{nickname}}Raw({{#allParams.0}}requestParameters, {{/allParams.0}}initOverrides);
return await response.value();
Expand Down
10 changes: 5 additions & 5 deletions samples/client/petstore/typescript-fetch/builds/default-v3.0/apis/FakeApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of outer boolean types
*/
async fakeOuterBooleanSerialize(requestParameters: FakeOuterBooleanSerializeRequest, initOverrides?: RequestInit): Promise<boolean> {
async fakeOuterBooleanSerialize(requestParameters: FakeOuterBooleanSerializeRequest = {}, initOverrides?: RequestInit): Promise<boolean> {
const response = await this.fakeOuterBooleanSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
Expand Down Expand Up @@ -261,7 +261,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of object with outer number type
*/
async fakeOuterCompositeSerialize(requestParameters: FakeOuterCompositeSerializeRequest, initOverrides?: RequestInit): Promise<OuterComposite> {
async fakeOuterCompositeSerialize(requestParameters: FakeOuterCompositeSerializeRequest = {}, initOverrides?: RequestInit): Promise<OuterComposite> {
const response = await this.fakeOuterCompositeSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
Expand Down Expand Up @@ -290,7 +290,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of outer number types
*/
async fakeOuterNumberSerialize(requestParameters: FakeOuterNumberSerializeRequest, initOverrides?: RequestInit): Promise<number> {
async fakeOuterNumberSerialize(requestParameters: FakeOuterNumberSerializeRequest = {}, initOverrides?: RequestInit): Promise<number> {
const response = await this.fakeOuterNumberSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
Expand Down Expand Up @@ -319,7 +319,7 @@ export class FakeApi extends runtime.BaseAPI {
/**
* Test serialization of outer string types
*/
async fakeOuterStringSerialize(requestParameters: FakeOuterStringSerializeRequest, initOverrides?: RequestInit): Promise<string> {
async fakeOuterStringSerialize(requestParameters: FakeOuterStringSerializeRequest = {}, initOverrides?: RequestInit): Promise<string> {
const response = await this.fakeOuterStringSerializeRaw(requestParameters, initOverrides);
return await response.value();
}
Expand Down Expand Up @@ -683,7 +683,7 @@ export class FakeApi extends runtime.BaseAPI {
* To test enum parameters
* To test enum parameters
*/
async testEnumParameters(requestParameters: TestEnumParametersRequest, initOverrides?: RequestInit): Promise<void> {
async testEnumParameters(requestParameters: TestEnumParametersRequest = {}, initOverrides?: RequestInit): Promise<void> {
await this.testEnumParametersRaw(requestParameters, initOverrides);
}

Expand Down
8 changes: 4 additions & 4 deletions samples/client/petstore/typescript-fetch/builds/enum/apis/DefaultApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export class DefaultApi extends runtime.BaseAPI {

/**
*/
async fakeEnumRequestGetInline(requestParameters: FakeEnumRequestGetInlineRequest, initOverrides?: RequestInit): Promise<InlineResponse200> {
async fakeEnumRequestGetInline(requestParameters: FakeEnumRequestGetInlineRequest = {}, initOverrides?: RequestInit): Promise<InlineResponse200> {
const response = await this.fakeEnumRequestGetInlineRaw(requestParameters, initOverrides);
return await response.value();
}
Expand Down Expand Up @@ -134,7 +134,7 @@ export class DefaultApi extends runtime.BaseAPI {

/**
*/
async fakeEnumRequestGetRef(requestParameters: FakeEnumRequestGetRefRequest, initOverrides?: RequestInit): Promise<EnumPatternObject> {
async fakeEnumRequestGetRef(requestParameters: FakeEnumRequestGetRefRequest = {}, initOverrides?: RequestInit): Promise<EnumPatternObject> {
const response = await this.fakeEnumRequestGetRefRaw(requestParameters, initOverrides);
return await response.value();
}
Expand All @@ -161,7 +161,7 @@ export class DefaultApi extends runtime.BaseAPI {

/**
*/
async fakeEnumRequestPostInline(requestParameters: FakeEnumRequestPostInlineRequest, initOverrides?: RequestInit): Promise<InlineObject> {
async fakeEnumRequestPostInline(requestParameters: FakeEnumRequestPostInlineRequest = {}, initOverrides?: RequestInit): Promise<InlineObject> {
const response = await this.fakeEnumRequestPostInlineRaw(requestParameters, initOverrides);
return await response.value();
}
Expand All @@ -188,7 +188,7 @@ export class DefaultApi extends runtime.BaseAPI {

/**
*/
async fakeEnumRequestPostRef(requestParameters: FakeEnumRequestPostRefRequest, initOverrides?: RequestInit): Promise<EnumPatternObject> {
async fakeEnumRequestPostRef(requestParameters: FakeEnumRequestPostRefRequest = {}, initOverrides?: RequestInit): Promise<EnumPatternObject> {
const response = await this.fakeEnumRequestPostRefRaw(requestParameters, initOverrides);
return await response.value();
}
Expand Down