Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Default auth method support and optional param object when all params optional #11321

Merged
merged 23 commits into from
Jan 22, 2022

Conversation

davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Jan 14, 2022

Add an optional default?: SecurityAuthentication field to the AuthMethodsConfiguration type that populates a similarly typed optional field on the AuthMethods type.
This enables passing a custom object satisfying the SecurityAuthentication interface for authentication purposes in the config either when a client is created or overriding at api call time via config param.

Also carry over optional singleParameter when all params optional from here

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

@davidgamero
Copy link
Contributor Author

I'm happy to split this into two separate PR's if this is too messy btw

Copy link
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! :)
I think we can keep it as 1 PR - it's not messy at all and quite easy to read & understand.

Added a couple comments with questions and a small change.

@davidgamero
Copy link
Contributor Author

i've moved the default auth option to the config param instead to keep the override functinality

@davidgamero davidgamero requested a review from TiFu January 21, 2022 02:30
@davidgamero
Copy link
Contributor Author

ive excluded the inversify portion since the injection was essentially a whole separate feature

@OliverMKing
Copy link

Really looking forward to this change 😄.

@TiFu
Copy link
Contributor

TiFu commented Jan 22, 2022

LGTM! Many thanks for the PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants