Update parser to 2.0.29

[wing328]

Update parser to 2.0.29

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[wing328]

Updating the samples resulted in
[pool-1-thread-8] Finished generating python-fastapi… [pool-1-thread-6] Generation failed for python-experimental: (RuntimeException) Could not process model 'NullableShape'.Please make sure that your schema is correct! java.lang.RuntimeException: Could not process model 'NullableShape'.Please make sure that your schema is correct! at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:492) at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:888) at org.openapitools.codegen.cmd.GenerateBatch$GenerationRunner.run(GenerateBatch.java:232) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.lang.NullPointerException at org.openapitools.codegen.utils.ModelUtils.getSimpleRef(ModelUtils.java:384) at org.openapitools.codegen.DefaultCodegen.getOneOfAnyOfDescendants(DefaultCodegen.java:3089) at org.openapitools.codegen.DefaultCodegen.createDiscriminator(DefaultCodegen.java:3233) at org.openapitools.codegen.DefaultCodegen.fromModel(DefaultCodegen.java:2695) at org.openapitools.codegen.languages.PythonExperimentalClientCodegen.fromModel(PythonExperimentalClientCodegen.java:1057) at org.openapitools.codegen.DefaultGenerator.processModels(DefaultGenerator.java:1265) at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:487) ... 5 more [pool-1-thread-2] Generating python-legacy (outputs to /Users/williamcheng/Code/openapi-generator2/samples/client/petstore/python-legacy)… ERROR: One or more generators failed to generate. Halting ensure-up-to-date scripts.

[wing328]

@spacether I wonder if you can take a look at the NPE above when you've time? Thanks.

[wing328]

UPDATE: I've pushed e1bffbc to better handle the NPE

[spacether]

@wing328
Something is not working right here. The schema is:

    NullableShape:
      description: The value may be a shape or the 'null' value.
        The 'nullable' attribute was introduced in OAS schema >= 3.0
        and has been deprecated in OAS schema >= 3.1.
        For a nullable composed schema to work, one of its chosen oneOf schemas must be type null
      oneOf:
        - $ref: '#/components/schemas/Triangle'
        - $ref: '#/components/schemas/Quadrilateral'
        - type: null
      discriminator:
        propertyName: shapeType
      nullable: true

So the 3rd oneOf schema should be NoneSchema NOT AnyTypeSchema.
AnyTypeSchema is {} or true

[wing328]

Yup, could be a regression. I tried updating the parser to 2.0.30 (released several hours ago) but no luck (no change in samples).

Can you please report the issue to swagger parser directly with the details when you've time?

[spacether]

Yup, it could also be our code not seeing the null type right. If it is the parser I will report it.

[spacether]

I did some investigating here:

1. For yaml type: null the schema is defined as an type: null AnyType schema by swagger-parser
2. For yaml type: "null" the schema is correctly defined as type: "null" NoneSchema by swagger-parser
   So I will:

• Update the spec to make the type be the quoted null value
• Remove the discriminator from that schema because per the openapi spec, when discriminator exists, then the discriminator key MUST exist in the payload. a null payload value cannot meet that constraint.
• Remove nullable: true because it had no impact on this schema and the type: "null" in the oneOf already allows null as does having an untyped composed schema.