Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Adding Custom Agent Support for fetch call #11400

Merged
merged 9 commits into from
Jan 28, 2022

Conversation

davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Jan 25, 2022

Adding agent: http.Agent | https.Agent | undefined instance variable on the RequestContext class as well as the following methods:

setAgent(agent: http.Agent | https.Agent)
getAgent() : http.Agent | https.Agent | undefined

Then, the isomorphic fetch implementation would call getAgent() to pass the value into the agent option on the fetch call in isomorphic-fetch.ts

Implements #11394

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good.
Can you please revert the deleted files and update the samples?

@davidgamero
Copy link
Contributor Author

yep merging master back in now

@macjohnny
Copy link
Member

@TiFu are you fine with this change?

@davidgamero
Copy link
Contributor Author

davidgamero commented Jan 25, 2022

ended up excluding the web fetch since the lib doesn't list agent support, so it's just for the nodejs

Copy link
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the PR! :)

@TiFu TiFu merged commit b2bb5d0 into OpenAPITools:master Jan 28, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants