Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] jersey 2.35 #11661

Merged
merged 1 commit into from
Feb 20, 2022
Merged

[java] jersey 2.35 #11661

merged 1 commit into from
Feb 20, 2022

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 19, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sullis sullis requested a review from wing328 February 19, 2022 05:22
@wing328
Copy link
Member

wing328 commented Feb 19, 2022

Thanks for the PR. Please update the samples: https://github.com/OpenAPITools/openapi-generator/runs/5257009066?check_suite_focus=true

@sullis sullis force-pushed the jersey2-version-2.35 branch from 2bceb1f to 5ae29a3 Compare February 19, 2022 16:14
@sullis
Copy link
Contributor Author

sullis commented Feb 19, 2022

@wing328 I fixed the samples. All tests are passing.

@wing328 wing328 merged commit c5745f8 into master Feb 20, 2022
@wing328 wing328 deleted the jersey2-version-2.35 branch February 20, 2022 03:12
@wing328 wing328 added this to the 6.0.0 milestone Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants